Channel home: add support for stations - #9620
Conversation
|
Viewing it on the home page is fine without the YouTube.js PR but viewing it in a playlist needs that PR. |
Related FreeTube PR: FreeTubeApp/FreeTube#9620 This PR adds `station` as a lockupview type and will treat it like a video. Example: Michael Jackson Home page: https://www.youtube.com/channel/UC5OrDvL9DscpcAstz7JnQGA Michael Jackson Playlist page: https://www.youtube.com/playlist?list=PLUeQUfurHN6YO6GynESHaAA4oKJYFutPh
|
Stations can also be listed in search results and up next section does this PR support that? |
It was supported in search results, it should be supported in Up Next section with my latest commit (I haven't been able to test this) |
08c7979 to
cec87ae
Compare
|
Can be undrafted :) |
cec87ae to
c18e7ac
Compare
github-actions
Bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
Verified that Station is available on Home tab, within a playlist, search page and up next section.
Would it be possible to label it Station instead of Live?
|
Should now display "Station" and show an icon like YouTube does. YouTube: |
ae708b7 to
6980f59
Compare
|
Hmm, playing the station video was working for me about a week ago but seems to be failing with this error for me now:
|
Ah yes that too bad, its just a live stream but branded a bit diff and acts a bit diff. Welp at least we show it for when we fix it ig So same as #9545 |
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
Did not test search page and up next section but I can play it (I guess SABR enforcement not there yet for me
|
|
||
| description.value = props.data.description | ||
| isLive.value = props.data.liveNow || props.data.lengthSeconds === undefined | ||
| isStation.value = props.data.isStation === true |
There was a problem hiding this comment.
Probably not worth invalidating two reviews but could have been props.data.isStation
There is no other place in the code base (except for 4 getSubscriptionForX methods in utils.js) where boolean is enforced like this
github-actions
Bot
removed
the
PR: waiting for review
6 participants
Pull Request Type
Related issue
closes #9602
Description
I believe stations would work but I'm getting the HLS manifest missing error.
Screenshots
Testing
Go to: https://www.youtube.com/channel/UC5OrDvL9DscpcAstz7JnQGA
See:
Michael Jackson: The Stationon home pageGo to: https://www.youtube.com/playlist?list=PLUeQUfurHN6YO6GynESHaAA4oKJYFutPh
See:
Michael Jackson: The Stationon playlist page (requires YouTube.js update)Desktop